
utils.py
About this file
The file creates and stores event object for updating the request information into database.
Code Issues
-
It is unclear what is the difference between the
previous_value
andnew_value
in functioncreate_request_info_event()
. We know that the function updates events object request information. It is difficult to understand in this file what part of information of the events these values represent and what is the need of both the values. Though it becomes more clear in theviews.py
file that it is trying to update the agency title and agency request summary privacy options, a short summary can be given in this file itself maybe in the docstring.
Code Check Report
app/request/api/utils.py:20:25: W292 no newline at end of file
Documentation drawn from source code
create_request_info_event(request_id, type_, previous_value, new_value):
Create and store events object for updating the request information into database.:param request_id: request ID:param type_: event type:param previous_value: previous value:param new_value: new value